Allow cluster-dumping only certain workers #6229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results 16 files ± 0 16 suites ±0 7h 37m 46s ⏱️ - 12m 53s For more details on these failures, see this check. Results for commit 7be1691. ± Comparison against base commit b6a62f8. ♻️ This comment has been updated with latest results. |
sjperkins
reviewed
Apr 28, 2022
sjperkins
suggested changes
Apr 28, 2022
There was a problem hiding this comment.
This looks like a useful debugging addition and I think its been implemented well.
It looks like mypy is complaining about the types being passed to the new workers argument of dump_cluster_state.
Also, looks like test_release_evloop_while_spilling added in #6189 is flaky on macos. cc @crusaderky.
Co-authored-by: Simon Perkins <simon.perkins@gmail.com>
|
@gjoseph92 status? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to cluster-dump large clusters, when you know only a handful of workers are actually problematic (as is usually the case in a deadlock).
pre-commit run --all-files