Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout and check on write #653

Merged
merged 2 commits into from
Nov 11, 2016
Merged

Timeout and check on write #653

merged 2 commits into from
Nov 11, 2016

Commits on Nov 11, 2016

  1. Timeout and check on write 

    The core.write coroutine waits on IOStream.write futures.  However, there are
some cases where IOStream.write futures don't complete.  Notably if something
else writes to the same stream before we're done waiting then the first future
is forgotten and hangs forever.

    If `write` is called again before that `.Future` has resolved, the
    previous future will be orphaned and will never resolve.

This solution wraps the wait in a timeout and checks the stream's
write_buffer as a secondary check for completion.  There are probably better
solutions but this seems to work fine.
    @mrocklin
    mrocklin committed Nov 11, 2016
    Configuration menu
    Copy the full SHA
    a52cf4a View commit details
    Browse the repository at this point in the history

  2. Remove timeout trick from batched 

    This was recently moved to core.write
    @mrocklin
    mrocklin committed Nov 11, 2016
    Configuration menu
    Copy the full SHA
    6259c60 View commit details
    Browse the repository at this point in the history