Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically mark all WorkerState tests #6706

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

crusaderky
Copy link
Collaborator

Automatically mark all tests that use the ws or the ws_with_running_task fixtures.
This allows running all and only such tests with pytest -m workerstate.

This in turn will allow, in the future,

  • to measure and progressively increase test coverage of WorkerState._transition_* using deterministic WorkerState tests only
  • to give developers a quick way to retest after changes to the transitions machinery.

@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±0         15 suites  ±0   6h 34m 14s ⏱️ + 13m 52s
  2 950 tests ±0    2 863 ✔️  - 1       85 💤  - 1  2 +2 
21 872 runs  ±0  20 852 ✔️ +2  1 018 💤  - 4  2 +2 

For more details on these failures, see this check.

Results for commit 97332b4. ± Comparison against base commit 6765e6e.

Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great idea! I could foresee this flag getting blurry at some point in the future, but that's a problem to tackle at that point in time.

@crusaderky crusaderky merged commit 3ff6be1 into dask:main Jul 11, 2022
@crusaderky crusaderky deleted the mark_ws_tests branch July 11, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants