Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restart wait for workers edge case #6823

Merged

Conversation

gjoseph92
Copy link
Collaborator

restart would poll for new workers on a 0.2s interval. If a worker joined in the 0.2s after the final check, but before the timeout had expired, we'd raise a confusing error claiming not all workers had returned, but also demonstrating that they had.

Closes #6821

  • Tests added / passed
  • Passes pre-commit run --all-files

`restart` would poll for new workers on a 0.2s interval. If a worker joined in the 0.2s after the final check, but before the timeout had expired, we'd raise a confusing error claiming not all workers had returned, but also demonstrating that they had.
@gjoseph92 gjoseph92 self-assigned this Aug 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±0         15 suites  ±0   6h 15m 56s ⏱️ - 6m 0s
  2 989 tests +1    2 897 ✔️  - 1       89 💤 +1  2 ±0  1 🔥 +1 
22 165 runs  +8  21 115 ✔️ +5  1 046 💤 +1  3 +1  1 🔥 +1 

For more details on these failures and errors, see this check.

Results for commit f8188d6. ± Comparison against base commit 4f6960a.

Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch!

@gjoseph92 gjoseph92 merged commit 78be937 into dask:main Aug 3, 2022
@gjoseph92 gjoseph92 deleted the restart-fix-worker-join-in-last-poll-cycle branch August 3, 2022 14:51
gjoseph92 added a commit to gjoseph92/distributed that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test_worker_doesnt_await_task_completion
2 participants