Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return results in restart_workers #7606

Merged

Conversation

milesgranger
Copy link
Contributor

@milesgranger milesgranger commented Mar 1, 2023

Small extension to #7154 to return results from Client.restart_workers

  • Tests added / passed
  • Passes pre-commit run --all-files

Wasn't completely sure if testing an exception raised during restart ought to be handled here, but prior conversations suggest it can be ignored or otherwise logged as is.

In [3]: client.restart_workers(['tcp://127.0.0.1:37623'])
Out[3]: {'tcp://127.0.0.1:37623': 'OK'}

@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       24 files  +       1         24 suites  +1   11h 20m 32s ⏱️ + 9m 8s
  3 489 tests ±       0    3 380 ✔️ +       1     106 💤 ±  0  3  - 1 
40 995 runs  +1 291  39 130 ✔️ +1 263  1 862 💤 +29  3  - 1 

For more details on these failures, see this check.

Results for commit 1cde09b. ± Comparison against base commit 8585f98.

♻️ This comment has been updated with latest results.

@fjetter
Copy link
Member

fjetter commented Mar 1, 2023

There appears to be at least one related failure in distributed.tests.test_client:: test_restart_workers

Most of the failing tests are fixed by #7595. If you merge main/rebase this should look much better

@jrbourbeau jrbourbeau changed the title Return results in restart_workers Return results in restart_workers Mar 1, 2023
@milesgranger milesgranger force-pushed the feat-restart_workers-return-status branch from 5359651 to d452e30 Compare March 1, 2023 18:56
@milesgranger milesgranger force-pushed the feat-restart_workers-return-status branch from d452e30 to 1cde09b Compare March 1, 2023 19:03
@jrbourbeau
Copy link
Member

add to allowlist

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @milesgranger! This is in

Also, I noticed this is your first code contribution to this repository. Welcome!

@jrbourbeau jrbourbeau merged commit ba1d0a2 into dask:main Mar 2, 2023
@milesgranger milesgranger deleted the feat-restart_workers-return-status branch March 2, 2023 16:02
@fjetter
Copy link
Member

fjetter commented Mar 6, 2023

Sorry to "reopen" this. I believe we should add tests for a couple of cases with failing worker restarts. This is where this feature actually comes in handy.

@jrbourbeau
Copy link
Member

Makes sense -- @milesgranger would you mind adding some failing worker restarts test cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants