Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypy warning in test_client.py #7710

Merged
merged 2 commits into from Mar 28, 2023
Merged

Conversation

crusaderky
Copy link
Collaborator

Fix mypy warning:

distributed/tests/test_client.py:4831: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]

The warning appears whenever there's a mypy error anywhere and you run pre-commit run --all-files.

@crusaderky crusaderky self-assigned this Mar 27, 2023
@jrbourbeau jrbourbeau changed the title Fix mypy warning in test_client.py Fix mypy warning in test_client.py Mar 27, 2023
Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @crusaderky -- this LGTM

My guess is the test failures in CI are related to environment caching. I've pushed an empty commit that skips the env cache

@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       26 files  ±0         26 suites  ±0   12h 33m 44s ⏱️ - 1h 6m 12s
  3 542 tests ±0    3 434 ✔️ +154     104 💤 ±0  4  - 154 
44 788 runs  ±0  42 688 ✔️ +463  2 096 💤 +1  4  - 464 

For more details on these failures, see this check.

Results for commit a5271f6. ± Comparison against base commit 4b9892e.

@jrbourbeau jrbourbeau merged commit e922372 into dask:main Mar 28, 2023
28 of 33 checks passed
@crusaderky crusaderky deleted the mypy_test_client branch March 28, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants