Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up legacy cruft from worker reconnection #7712

Merged
merged 3 commits into from Mar 29, 2023

Conversation

crusaderky
Copy link
Collaborator

Worker reconnection was removed a while ago. None of this is needed anymore.

@crusaderky crusaderky self-assigned this Mar 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2023

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       26 files  ±0         26 suites  ±0   12h 20m 36s ⏱️ - 1m 39s
  3 541 tests ±0    3 433 ✔️  - 1     104 💤 ±0  4 +1 
44 799 runs  ±0  42 697 ✔️  - 5  2 098 💤 +4  4 +1 

For more details on these failures, see this check.

Results for commit 491bb84. ± Comparison against base commit ab95634.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.
distributed.tests.test_scheduler ‑ test_new_worker_with_data_rejected
distributed.tests.test_scheduler ‑ test_worker_arrives_with_processing_data
distributed.tests.test_scheduler ‑ test_nonempty_data_is_rejected
distributed.tests.test_scheduler ‑ test_worker_arrives_with_data_is_rejected

♻️ This comment has been updated with latest results.

@crusaderky crusaderky merged commit 0d39c19 into dask:main Mar 29, 2023
26 of 31 checks passed
@crusaderky crusaderky deleted the register_empty_data branch March 29, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants