New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a dashboard component that displays RMM memory #7718
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pushing this forward @pentschev. This looks good to me.
I hope you don't mind @pentschev but I've pushed a commit to fix up the linting and tweak an extra line. I'll leave this to sit for a bit in case other folks want to weigh in, but otherwise, I intend to merge this tomorrow. |
Sure thing, thank Jacob! |
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 26 files + 1 26 suites +1 12h 10m 10s ⏱️ - 18m 35s For more details on these failures, see this check. Results for commit f2c398b. ± Comparison against base commit 0d39c19. |
Test failures appear unrelated. Merging. |
Thanks @jacobtomlinson ! |
This is an overhaul of #5740 , primarily updating colors as requested in that PR's review, which adds a visualization that provides a bit more information than the current GPU memory utilization plot. It also shows the amount of GPU memory being managed by RMM, and in the case of a RMM pool, the amount of pool memory actually used:
There are green bars with varying opacity representing from left to right: the amount of memory used from the RMM pool, the amount of free memory in the RMM pool and the amount of memory allocated outside of the RMM pool.
pre-commit run --all-files