Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dashboard component that displays RMM memory #7718

Merged
merged 18 commits into from Mar 30, 2023

Conversation

pentschev
Copy link
Member

This is an overhaul of #5740 , primarily updating colors as requested in that PR's review, which adds a visualization that provides a bit more information than the current GPU memory utilization plot. It also shows the amount of GPU memory being managed by RMM, and in the case of a RMM pool, the amount of pool memory actually used:

Screenshot 2023-03-29 at 15 35 29

There are green bars with varying opacity representing from left to right: the amount of memory used from the RMM pool, the amount of free memory in the RMM pool and the amount of memory allocated outside of the RMM pool.

  • Tests added / passed
  • Passes pre-commit run --all-files

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing this forward @pentschev. This looks good to me.

distributed/dashboard/components/rmm.py Outdated Show resolved Hide resolved
@jacobtomlinson
Copy link
Member

I hope you don't mind @pentschev but I've pushed a commit to fix up the linting and tweak an extra line. I'll leave this to sit for a bit in case other folks want to weigh in, but otherwise, I intend to merge this tomorrow.

@pentschev
Copy link
Member Author

I hope you don't mind @pentschev but I've pushed a commit to fix up the linting and tweak an extra line. I'll leave this to sit for a bit in case other folks want to weigh in, but otherwise, I intend to merge this tomorrow.

Sure thing, thank Jacob!

@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       26 files  +    1         26 suites  +1   12h 10m 10s ⏱️ - 18m 35s
  3 544 tests +    1    3 437 ✔️ +    1     105 💤 +  1  2  - 1 
43 845 runs  +343  41 768 ✔️ +288  2 075 💤 +56  2  - 1 

For more details on these failures, see this check.

Results for commit f2c398b. ± Comparison against base commit 0d39c19.

@jacobtomlinson
Copy link
Member

Test failures appear unrelated. Merging.

@jacobtomlinson jacobtomlinson merged commit 24da06a into dask:main Mar 30, 2023
27 of 31 checks passed
@pentschev
Copy link
Member Author

Thanks @jacobtomlinson !

@pentschev pentschev deleted the add-rmm-diagnostics branch October 13, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants