New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scheduler.py typing - remove allow_incomplete_defs
#7721
Conversation
Some nits only. It should be just a matter of committing all suggestions and we're ready to go. |
Co-authored-by: crusaderky <crusaderky@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as soon as CI turns out green
github actions is down at the moment https://www.githubstatus.com/incidents/z3c6q056q332 so CI looks green but the mypy check didn't run |
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 25 files - 1 25 suites - 1 12h 52m 30s ⏱️ - 1h 35m 23s For more details on these failures and errors, see this check. Results for commit c420811. ± Comparison against base commit 215f379. ♻️ This comment has been updated with latest results. |
0cf75c6
to
c4097ba
Compare
This removes the flag for
allow_incomplete_defs
from scheduler.py. The step forallow_untyped_defs
is rather minimal and concerns mostlyScheduler.__init__
but I stopped and leave this to another PR.I do not intend do engage on a thorough review/feedback cycle unless something is horribly wrong. This is supposed to be a quick drive by to enable this flag. We can correct inaccurate types in follow up iterations. Spending too much time on this being open just increases risk of having merge conflicts, i.e. I would prefer addressing any review comments in a follow up