Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduler.py typing - remove allow_incomplete_defs #7721

Merged
merged 8 commits into from Mar 31, 2023

Conversation

fjetter
Copy link
Member

@fjetter fjetter commented Mar 29, 2023

This removes the flag for allow_incomplete_defs from scheduler.py. The step for allow_untyped_defs is rather minimal and concerns mostly Scheduler.__init__ but I stopped and leave this to another PR.

I do not intend do engage on a thorough review/feedback cycle unless something is horribly wrong. This is supposed to be a quick drive by to enable this flag. We can correct inaccurate types in follow up iterations. Spending too much time on this being open just increases risk of having merge conflicts, i.e. I would prefer addressing any review comments in a follow up

@crusaderky crusaderky self-requested a review March 29, 2023 14:27
distributed/scheduler.py Outdated Show resolved Hide resolved
distributed/scheduler.py Outdated Show resolved Hide resolved
distributed/scheduler.py Outdated Show resolved Hide resolved
distributed/scheduler.py Outdated Show resolved Hide resolved
distributed/scheduler.py Outdated Show resolved Hide resolved
distributed/scheduler.py Outdated Show resolved Hide resolved
distributed/scheduler.py Outdated Show resolved Hide resolved
distributed/scheduler.py Outdated Show resolved Hide resolved
distributed/scheduler.py Outdated Show resolved Hide resolved
distributed/scheduler.py Outdated Show resolved Hide resolved
@crusaderky
Copy link
Collaborator

Some nits only. It should be just a matter of committing all suggestions and we're ready to go.

Co-authored-by: crusaderky <crusaderky@gmail.com>
Copy link
Collaborator

@crusaderky crusaderky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as soon as CI turns out green

@graingert
Copy link
Member

github actions is down at the moment https://www.githubstatus.com/incidents/z3c6q056q332 so CI looks green but the mypy check didn't run

@crusaderky crusaderky closed this Mar 30, 2023
@crusaderky crusaderky reopened this Mar 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 30, 2023

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       25 files   -        1         25 suites   - 1   12h 52m 30s ⏱️ - 1h 35m 23s
  3 545 tests ±       0    3 432 ✔️ +       4     106 💤 ±  0    5  - 6  2 🔥 +2 
43 548 runs   - 1 297  41 319 ✔️  - 1 259  2 201 💤  - 35  26  - 5  2 🔥 +2 

For more details on these failures and errors, see this check.

Results for commit c420811. ± Comparison against base commit 215f379.

♻️ This comment has been updated with latest results.

@fjetter fjetter merged commit 31b398b into dask:main Mar 31, 2023
18 of 34 checks passed
@fjetter fjetter deleted the schduler_typing branch March 31, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants