Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test for DataFrame.to_hdf #7735

Merged
merged 1 commit into from Mar 31, 2023
Merged

Conversation

hendrikmakait
Copy link
Member

@hendrikmakait hendrikmakait commented Mar 31, 2023

Follow-up to #7720 removing the test again since the functionality will be removed.

  • Tests added / passed
  • Passes pre-commit run --all-files

@hendrikmakait
Copy link
Member Author

Test failures on CI are unrelated.

Copy link
Member

@ncclementi ncclementi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       25 files   -        1         25 suites   - 1   14h 11m 38s ⏱️ - 42m 33s
  3 545 tests  -        1    3 434 ✔️ +       3     106 💤 ±  0    5  -   2 
43 545 runs   - 1 312  41 322 ✔️  - 1 260  2 198 💤  - 37  25  - 13 

For more details on these failures, see this check.

Results for commit 3879f95. ± Comparison against base commit 5494138.

This pull request removes 1 test.
distributed.shuffle.tests.test_shuffle ‑ test_shuffle_before_to_hdf

@hendrikmakait hendrikmakait merged commit d1080d2 into dask:main Mar 31, 2023
17 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants