Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop id from RMM dashboard component #7739

Merged
merged 2 commits into from Apr 3, 2023
Merged

Conversation

jrbourbeau
Copy link
Member

We made similar changes previously here #5648

Closes #7731

cc @jacobtomlinson @pentschev

@pentschev
Copy link
Member

Thanks @jrbourbeau for that, I wasn't able to reproduce it locally earlier and got sidetracked by other things, I'm glad you knew how to fix it! 😄

@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       26 files  ±0         26 suites  ±0   14h 15m 29s ⏱️ + 35m 30s
  3 545 tests ±0    3 434 ✔️ +  3     106 💤 ±0  5  -   3 
44 845 runs  ±0  42 604 ✔️ +21  2 236 💤 +2  5  - 23 

For more details on these failures, see this check.

Results for commit d10c077. ± Comparison against base commit d1080d2.

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jrbourbeau

@jacobtomlinson jacobtomlinson merged commit 28a28d7 into dask:main Apr 3, 2023
26 of 33 checks passed
@jrbourbeau jrbourbeau deleted the rmm-id branch April 3, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError: 'id' cannot be used together with property initializers in RMM
3 participants