Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge identical tool.mypy.overrides sections #7749

Merged
merged 1 commit into from Apr 5, 2023

Conversation

graingert
Copy link
Member

@graingert graingert commented Apr 5, 2023

after #7629 I noticed it was possible to merge identical tool.mypy.overrides sections

  • Tests added / passed
  • Passes pre-commit run --all-files

@graingert graingert marked this pull request as ready for review April 5, 2023 11:42
@graingert graingert requested a review from fjetter as a code owner April 5, 2023 11:42
@graingert graingert force-pushed the cleanup-tool-mypy-overrides branch from 8d84bc7 to ab9ad5c Compare April 5, 2023 11:45
@graingert graingert changed the title cleanup tool.mypy.overrides merge identical tool.mypy.overrides sections Apr 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       26 files  ±0         26 suites  ±0   14h 43m 17s ⏱️ + 23m 33s
  3 546 tests ±0    3 436 ✔️ +4     106 💤 ±0    4  - 3 
44 858 runs   - 1  42 607 ✔️ +5  2 236 💤  - 2  15  - 3 

For more details on these failures, see this check.

Results for commit ab9ad5c. ± Comparison against base commit 1511b77.

@jrbourbeau jrbourbeau changed the title merge identical tool.mypy.overrides sections Merge identical tool.mypy.overrides sections Apr 5, 2023
Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @graingert

Note that CI failures are unrelated and have been resolved in main

@jrbourbeau jrbourbeau merged commit ea2b7fe into dask:main Apr 5, 2023
20 of 34 checks passed
@graingert graingert deleted the cleanup-tool-mypy-overrides branch April 5, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants