Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a timeout to client.as_completed that mirrors concurrent.futures.as_completed's timeout #7811

Merged
merged 5 commits into from Jun 6, 2023

Conversation

graingert
Copy link
Member

Closes #7751

  • Tests added / passed
  • Passes pre-commit run --all-files

@github-actions
Copy link
Contributor

github-actions bot commented Apr 27, 2023

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       20 files  ±  0         20 suites  ±0   11h 48m 0s ⏱️ + 19m 49s
  3 661 tests +  2    3 551 ✔️ +  1     108 💤 ±0  2 +1 
35 400 runs  +20  33 634 ✔️ +19  1 764 💤 ±0  2 +1 

For more details on these failures, see this check.

Results for commit 451e441. ± Comparison against base commit 8301cb7.

♻️ This comment has been updated with latest results.

@graingert graingert force-pushed the add-timeout-to-as-completed branch from 5d6b10b to 5ba4b10 Compare May 4, 2023 13:19
@graingert graingert marked this pull request as ready for review May 4, 2023 14:21
@graingert graingert requested a review from fjetter as a code owner May 4, 2023 14:21
@hendrikmakait hendrikmakait self-requested a review May 5, 2023 08:04
distributed/client.py Outdated Show resolved Hide resolved
@hendrikmakait hendrikmakait added the needs review Needs review from a contributor. label May 10, 2023
Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @graingert!

distributed/client.py Outdated Show resolved Hide resolved
@hendrikmakait hendrikmakait merged commit ad73f7e into dask:main Jun 6, 2023
22 of 27 checks passed
This was referenced Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Needs review from a contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add a timeout to client.as_completed that mirrors concurrent.futures.as_completed's timeout
3 participants