Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test_protocol.py #7829

Merged
merged 1 commit into from May 11, 2023
Merged

Refactor test_protocol.py #7829

merged 1 commit into from May 11, 2023

Conversation

crusaderky
Copy link
Collaborator

Move tests about compression from test_protocol.py to test_compression.py.
This is just a refactor; tests have not been changed.

@crusaderky crusaderky requested a review from fjetter as a code owner May 10, 2023 17:43
@crusaderky crusaderky self-assigned this May 10, 2023
@crusaderky crusaderky added the needs review Needs review from a contributor. label May 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2023

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       26 files  +         6         26 suites  +6   15h 53m 23s ⏱️ + 4h 33m 24s
  3 581 tests ±         0    3 473 ✔️ +       11     105 💤  -   10  3  - 1 
45 340 runs  +13 024  43 174 ✔️ +12 319  2 163 💤 +706  3  - 1 

For more details on these failures, see this check.

Results for commit f9fb3cf. ± Comparison against base commit f4f4718.

This pull request removes 44 and adds 44 tests. Note that renamed tests count towards both.
distributed.protocol.tests.test_protocol ‑ test_auto_compression
distributed.protocol.tests.test_protocol ‑ test_compression_1
distributed.protocol.tests.test_protocol ‑ test_compression_2
distributed.protocol.tests.test_protocol ‑ test_compression_3
distributed.protocol.tests.test_protocol ‑ test_compression_thread_safety[None-bytes]
distributed.protocol.tests.test_protocol ‑ test_compression_thread_safety[None-memoryview]
distributed.protocol.tests.test_protocol ‑ test_compression_thread_safety[lz4-bytes]
distributed.protocol.tests.test_protocol ‑ test_compression_thread_safety[lz4-memoryview]
distributed.protocol.tests.test_protocol ‑ test_compression_thread_safety[snappy-bytes]
distributed.protocol.tests.test_protocol ‑ test_compression_thread_safety[snappy-memoryview]
…
distributed.protocol.tests.test_compression ‑ test_auto_compression
distributed.protocol.tests.test_compression ‑ test_compression_1
distributed.protocol.tests.test_compression ‑ test_compression_2
distributed.protocol.tests.test_compression ‑ test_compression_3
distributed.protocol.tests.test_compression ‑ test_compression_thread_safety[None-bytes]
distributed.protocol.tests.test_compression ‑ test_compression_thread_safety[None-memoryview]
distributed.protocol.tests.test_compression ‑ test_compression_thread_safety[lz4-bytes]
distributed.protocol.tests.test_compression ‑ test_compression_thread_safety[lz4-memoryview]
distributed.protocol.tests.test_compression ‑ test_compression_thread_safety[snappy-bytes]
distributed.protocol.tests.test_compression ‑ test_compression_thread_safety[snappy-memoryview]
…

♻️ This comment has been updated with latest results.

@fjetter fjetter merged commit 9d90792 into dask:main May 11, 2023
28 of 33 checks passed
milesgranger pushed a commit to milesgranger/distributed that referenced this pull request May 15, 2023
@crusaderky crusaderky deleted the compression_tests branch May 22, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Needs review from a contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants