Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docstring for batch_size in client.map #7833

Merged
merged 1 commit into from May 11, 2023

Conversation

dchudz
Copy link
Contributor

@dchudz dchudz commented May 11, 2023

closes #7382

@dchudz dchudz requested a review from fjetter as a code owner May 11, 2023 01:12
@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       26 files  +         6         26 suites  +6   15h 42m 9s ⏱️ + 4h 22m 10s
  3 581 tests ±         0    3 469 ✔️ +         7     105 💤  -   10  7 +3 
45 340 runs  +13 024  43 167 ✔️ +12 312  2 164 💤 +707  9 +5 

For more details on these failures, see this check.

Results for commit 2e4743c. ± Comparison against base commit f4f4718.

Copy link
Member

@fjetter fjetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would've preferred if the implementation actually did what the doc string said but that's unfortunately not true :(

Thanks for the fix

@fjetter fjetter merged commit 2d80271 into dask:main May 11, 2023
22 of 32 checks passed
milesgranger pushed a commit to milesgranger/distributed that referenced this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect batch_size docstring?
3 participants