New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 3.8 support #7840
Drop Python 3.8 support #7840
Conversation
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 20 files - 6 20 suites - 6 12h 18m 58s ⏱️ - 3h 3m 36s For more details on these failures, see this check. Results for commit dc76082. ± Comparison against base commit 6f70648. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @graingert! I just have a small question and two nits that don't block approval. From what I understand, we have lazy consensus in dask/community#315, so this should be good to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for handling all this @graingert. Overall this looks great -- just left a few small comments / questions
Also, it looks like we can drop some compatibility code here too
distributed/distributed/deploy/cluster.py
Lines 164 to 168 in e887fde
except asyncio.CancelledError: | |
# Task is being closed. When we drop Python < 3.8 we can drop | |
# this check (since CancelledError is not a subclass of | |
# Exception then). | |
break |
We should change https://github.com/graingert/distributed/blob/18e5421c31b6d8ceadcfa6cfecf1228072c67606/docs/source/develop.rst#L23 as well ( |
Co-authored-by: crusaderky <crusaderky@gmail.com>
Co-authored-by: Hendrik Makait <hendrik@makait.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @graingert. This looks good to go
EDIT: Waiting for CI to finish
Actually, |
@jrbourbeau just pushed a fix - I skip it on windows |
Thanks! Though we got a failure on macOS too https://github.com/dask/distributed/actions/runs/5069958811/jobs/9104314707?pr=7840 |
@jrbourbeau weird, I pushed a skip for that too |
The gpuCI failures here look unrelated to this PR but I've not seen them before (cc @charlesbluca). Checking over in #7857. Will merge this PR and dask/dask#10295 after we've confirmed they're not related |
Okay, seeing similar gpuCI failures over in #7857, so they're definitely unrelated to the changes here |
Thanks @graingert @crusaderky @hendrikmakait |
Closes dask/community#315
pre-commit run --all-files