Link TaskGroups to Spans #7869
Merged
Link TaskGroups to Spans #7869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
crusaderky
commented
May 30, 2023
•
crusaderky
commented
- Partial implementation of User-defined spans #7860
crusaderky
force-pushed
the
spans_taskgroups
branch
from
52d59a0
to
6a54542
Compare
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 20 files ± 0 20 suites ±0 12h 4m 7s ⏱️ + 46m 44s For more details on these failures, see this check. Results for commit 6a54542. ± Comparison against base commit 3286d2f. |
crusaderky
force-pushed
the
spans_taskgroups
branch
from
0b3a119
to
ec53bea
Compare
crusaderky
force-pushed
the
spans_taskgroups
branch
from
ec53bea
to
55971d8
Compare
hendrikmakait
approved these changes
May 31, 2023
| @@ -1063,6 +1063,12 @@ class TaskGroup: | |||
| #: Cumulative duration of all completed actions, by action | |||
| all_durations: defaultdict[str, float] | |||
|
|
|||
| #: Span ID (see distributed.spans). | |||
| #: It is possible to end up in situation where different tasks of the same TaskGroup | |||
There was a problem hiding this comment.
Conceptually, I feel like this shouldn't occur. I hope that we can avoid this scenario (or task groups altogether) with dask-expr in the future.
Co-authored-by: Hendrik Makait <hendrik@makait.com>
Co-authored-by: Hendrik Makait <hendrik@makait.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.