Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard: Fix Fine Performance Metrics w/ Bokeh 3 #7874

Merged
merged 2 commits into from Jun 1, 2023
Merged

Dashboard: Fix Fine Performance Metrics w/ Bokeh 3 #7874

merged 2 commits into from Jun 1, 2023

Conversation

milesgranger
Copy link
Contributor

@milesgranger milesgranger commented Jun 1, 2023 •
edited

Closes #7831

  • Tests added / passed
  • Passes pre-commit run --all-files

@milesgranger milesgranger added the needs review Needs review from a contributor. label Jun 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       20 files  +       1         20 suites  +1   11h 27m 32s ⏱️ + 28m 44s
  3 659 tests ±       0    3 548 ✔️  -        3     108 💤 ±  0  3 ❌ +3 
35 380 runs  +1 310  33 612 ✔️ +1 268  1 765 💤 +39  3 ❌ +3 

For more details on these failures, see this check.

Results for commit 28b2d31. ± Comparison against base commit 979adb2.

crusaderky
crusaderky approved these changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@crusaderky crusaderky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, thank you.
However see follow-up: #7875

@crusaderky crusaderky merged commit 8301cb7 into dask:main Jun 1, 2023
23 of 27 checks passed
jrbourbeau
jrbourbeau reviewed Jun 1, 2023
View reviewed changes
Copy link
Member

@jrbourbeau jrbourbeau left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @milesgranger!

@crusaderky do you have bandwidth to look at this?

EDIT: Looks like you did!

@milesgranger milesgranger deleted the milesgranger/7831-fine-perf-metrics-bokeh-3 branch June 1, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrbourbeau jrbourbeau jrbourbeau left review comments

@crusaderky crusaderky crusaderky approved these changes

@fjetter fjetter Awaiting requested review from fjetter fjetter is a code owner

Assignees
No one assigned
Labels
needs review Needs review from a contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fine Performance Metrics Dashboard is broken on Bokeh 3
3 participants
@milesgranger @crusaderky @jrbourbeau