Fix tests that disable the shuffle extension #7883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendrikmakait
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
Thanks, @crusaderky! Out-of-scope comment: The scheduler extension should probably be responsible for installing the worker extension to avoid such a situation entirely.
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 20 files ±0 20 suites ±0 12h 13m 1s ⏱️ + 10m 13s For more details on these failures, see this check. Results for commit 080206c. ± Comparison against base commit 2d4ff46. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In all tests that artificially disable the shuffle extension on the scheduler, Scheduler.heartbeat_worker crashes because the same extension is still active on the worker.