Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor P2P rechunk validation #7890

Merged
merged 4 commits into from Jun 12, 2023

Conversation

hendrikmakait
Copy link
Member

@hendrikmakait hendrikmakait commented Jun 7, 2023

Sibling to dask/dask#10336

  • Tests added / passed
  • Passes pre-commit run --all-files

continuous_integration/environment-3.10.yaml Outdated Show resolved Hide resolved
continuous_integration/environment-3.11.yaml Outdated Show resolved Hide resolved
continuous_integration/environment-3.9.yaml Outdated Show resolved Hide resolved
@hendrikmakait
Copy link
Member Author

cc @wence-

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       20 files  ±  0         20 suites  ±0   11h 28m 30s ⏱️ + 6m 14s
  3 679 tests +  3    3 569 ✔️ +  2     108 💤 ±0  2 +1 
35 580 runs  +32  33 813 ✔️ +30  1 765 💤 +1  2 +1 

For more details on these failures, see this check.

Results for commit 217bc3b. ± Comparison against base commit fdeb6b3.

This pull request removes 2 and adds 5 tests. Note that renamed tests count towards both.
distributed.dashboard.tests.test_scheduler_bokeh ‑ test_FinePerformanceMetrics_simulated_spill_no_crash
distributed.tests.test_scheduler ‑ test_cumulative_worker_metrics
distributed.tests.test_spans ‑ test_worker_metrics
distributed.tests.test_worker_metrics ‑ test_no_spans_extension
distributed.tests.test_worker_metrics ‑ test_reschedule
distributed.tests.test_worker_metrics ‑ test_send_metrics_to_scheduler
distributed.tests.test_worker_metrics ‑ test_user_metrics_weird

♻️ This comment has been updated with latest results.

Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so now that dask does this validation, there is no need to repeat it here.

@hendrikmakait hendrikmakait marked this pull request as ready for review June 12, 2023 10:27
@hendrikmakait hendrikmakait merged commit 19c8bf9 into dask:main Jun 12, 2023
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants