Avoid multiple data connections to the same worker #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We document worker state in the docstring. This helped to identify state that was no longer in use.
mrocklin
force-pushed
the
communication-overlap
branch
from
8eff11f
to
c548b56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workers manage multiple concurrent peer-to-peer connections. Each connection can gather multiple pieces of data from that worker Workers limit the number of simultaneously open connections at once to avoid spreading network bandwidth too thinly. They avoid gathering more than 200MB of extra data from a worker at once in order to keep high priority tasks from waiting on data of low priority tasks.
However, previously they might open several connections to the same worker, each collecting 200MB. This can overwhelm the connection, resulting in slower overall performance.
Now we restrict workers to only have one connection to a particular peer at a time. They can still have many connections open, but they must be to different peers.