Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky UCX tests #7950

Merged
merged 2 commits into from Jun 26, 2023
Merged

Fix flaky UCX tests #7950

merged 2 commits into from Jun 26, 2023

Conversation

pentschev
Copy link
Member

Closes #7944

Hardcoding ports can cause binding to fail, thus switching to dynamic ports should make test_ucx_config_w_env_var more reliable.

Additionally, some UCX tests (namely test_simple and test_transpose) may fail when running from gpuCI's Docker container, even though those are not reproducible on the host where Docker is running. This behavior probably occurs due to the limitation of resources in the container, thus we reduce number of workers and threads to some of the UCX tests, which will make them unlikely to fail while still testing basic UCX functionality.

  • Tests added / passed
  • Passes pre-commit run --all-files

Some UCX tests may fail when running from gpuCI's Docker container, even
though those are not reproducible on the host where Docker is running.
This behavior probably occurs due to the limitation of resources in the
container, thus we reduce number of workers and threads to some of the
UCX tests, which will make them unlikely to fail while still testing
basic UCX functionality.
@quasiben
Copy link
Member

Thanks @pentschev -- I'll merge in after tests pass

@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       20 files  +       1         20 suites  +1   11h 54m 22s ⏱️ + 36m 23s
  3 698 tests ±       0    3 586 ✔️ ±       0     106 💤 ±  0  6 ±0 
35 766 runs  +1 316  34 009 ✔️ +1 274  1 749 💤 +40  8 +2 

For more details on these failures, see this check.

Results for commit 4449f25. ± Comparison against base commit 3b0376f.

@quasiben
Copy link
Member

Failures here are unrelated. Merging in

@quasiben quasiben merged commit e4b95ca into dask:main Jun 26, 2023
21 of 28 checks passed
@pentschev
Copy link
Member Author

Thanks @quasiben !

@pentschev pentschev deleted the ucx-test-fixes branch October 13, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GPU CI failures in test_ucx_config_w_env_var
2 participants