Use distributed.wait_for in test_close_async_task_handles_cancellation
#7955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
force-pushed
the
replace-calls-to-asyncio-wait-for-with-distributed-wait-for
branch
from
756a273
to
2a7f049
Compare
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 20 files ±0 20 suites ±0 11h 56m 17s ⏱️ + 4m 35s For more details on these failures, see this check. Results for commit 2a7f049. ± Comparison against base commit a5beabf. |
jrbourbeau
changed the title
distributed.wait_for in test_close_async_task_handles_cancellation
jrbourbeau
approved these changes
Jun 28, 2023
graingert
deleted the
replace-calls-to-asyncio-wait-for-with-distributed-wait-for
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All distributed code should use distributed.utils.wait_for instead of asyncio.wait_for
I noticed this one slipped through
pre-commit run --all-files