Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove accidental duplicated conversion of pyarrow Table to pandas #7983

Merged
merged 1 commit into from Jul 11, 2023

Conversation

jorisvandenbossche
Copy link
Member

#7896 accidentally added a new df = table.to_pandas(..) call without removing the existing one, duplicating the conversion.

  • Tests added / passed
  • Passes pre-commit run --all-files

@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       20 files  +       1         20 suites  +1   10h 52m 21s ⏱️ + 5m 6s
  3 708 tests ±       0    3 597 ✔️  -        1     106 💤 ±  0  5 +1 
35 866 runs  +1 319  34 111 ✔️ +1 277  1 750 💤 +41  5 +1 

For more details on these failures, see this check.

Results for commit d793865. ± Comparison against base commit 9beab9a.

Copy link
Member

@fjetter fjetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm surprised this didn't blow up before due to the self destruct 🤔

@fjetter fjetter merged commit 722414f into dask:main Jul 11, 2023
21 of 28 checks passed
@jorisvandenbossche jorisvandenbossche deleted the clean-duplicated-conversion branch July 11, 2023 08:16
@jorisvandenbossche
Copy link
Member Author

Hmm, that's indeed a good point. With a tiny example, I directly get a segfault calling this twice:

In [1]: table = pa.table({"a": [0,2,3]})

In [2]: df = table.to_pandas(self_destruct=True)

In [3]: df = table.to_pandas(self_destruct=True)
Segmentation fault (core dumped)

Not sure why that doesn't happen in the test suite (or in practice people using this)

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrbourbeau jrbourbeau mentioned this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants