Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test when not repartitioning for p2p in set_index #8016

Merged
merged 2 commits into from Jul 20, 2023
Merged

Conversation

phofl
Copy link
Collaborator

@phofl phofl commented Jul 19, 2023

xref #8015

  • Tests added / passed
  • Passes pre-commit run --all-files

cc @hendrikmakait

@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       13 files   -        1         13 suites   - 1   6h 15m 18s ⏱️ - 41m 28s
  3 719 tests +       1    3 609 ✔️ +       3     108 💤 ±  0  2  - 2 
23 594 runs   - 1 312  22 449 ✔️  - 1 275  1 143 💤  - 35  2  - 2 

For more details on these failures, see this check.

Results for commit 625b979. ± Comparison against base commit d9a3457.

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a test @phofl

Are we sure this is testing what we want? This test passes when using the main branch of dask without dask/dask#10421

@phofl
Copy link
Collaborator Author

phofl commented Jul 20, 2023

We are just checking that the change does not break anything, it is supposed to pass on both versions

@jrbourbeau
Copy link
Member

Ah, I thought we were wanting to check that the extra repartition doesn't happen with p2p

@phofl
Copy link
Collaborator Author

phofl commented Jul 20, 2023

No just that behavior won’t change (that was my intent at least)

@jrbourbeau jrbourbeau merged commit fc41f4c into dask:main Jul 20, 2023
17 of 28 checks passed
@phofl phofl deleted the p2p branch July 20, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants