Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for GraphLayout with scatter #8025

Merged
merged 1 commit into from Jul 24, 2023

Conversation

j-bennet
Copy link
Contributor

@j-bennet j-bennet commented Jul 20, 2023

Replace a test for TypeError for GraphLayout with scatter - this one triggers the same error that the customer experienced.

Follow-up for #8017 (comment).

Closes #xxxx

  • Tests added / passed
  • Passes pre-commit run --all-files

@j-bennet j-bennet requested a review from fjetter as a code owner July 20, 2023 18:02
@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       20 files  +       18         20 suites  +18   11h 15m 4s ⏱️ + 10h 47m 13s
  3 735 tests +  1 741    3 624 ✔️ +  1 815     106 💤  -      79  5 +5 
36 130 runs  +32 311  34 377 ✔️ +30 943  1 748 💤 +1 363  5 +5 

For more details on these failures, see this check.

Results for commit 45ac3dc. ± Comparison against base commit 70c9eb8.

This pull request removes 1 and adds 1742 tests. Note that renamed tests count towards both.
distributed.diagnostics.tests.test_graph_layout ‑ test_layout_with_priorities
distributed.cli.tests.test_dask_scheduler ‑ test_dashboard
distributed.cli.tests.test_dask_scheduler ‑ test_dashboard_allowlist
distributed.cli.tests.test_dask_scheduler ‑ test_dashboard_non_standard_ports
distributed.cli.tests.test_dask_scheduler ‑ test_dashboard_port_zero
distributed.cli.tests.test_dask_scheduler ‑ test_defaults
distributed.cli.tests.test_dask_scheduler ‑ test_hostport
distributed.cli.tests.test_dask_scheduler ‑ test_idle_timeout
distributed.cli.tests.test_dask_scheduler ‑ test_interface
distributed.cli.tests.test_dask_scheduler ‑ test_multiple_protocols
distributed.cli.tests.test_dask_scheduler ‑ test_multiple_workers
…

@@ -102,11 +102,11 @@ async def test_unique_positions(c, s, a, b):


@gen_cluster(client=True)
async def test_layout_with_priorities(c, s, a, b):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this test been removed intentionally? (I'm just wondering because the description says this adds a test, not that it replaces one.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's intentional. In the initial PR, I added a test with priorities, but I don't think it actually triggered the error case.

Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @j-bennet!

@hendrikmakait hendrikmakait merged commit 16b0c51 into dask:main Jul 24, 2023
23 of 28 checks passed
@j-bennet j-bennet deleted the j-bennet/test-layout-with-scatter branch July 24, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants