Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility variable naming #8030

Merged
merged 2 commits into from Jul 24, 2023
Merged

Fix compatibility variable naming #8030

merged 2 commits into from Jul 24, 2023

Conversation

hendrikmakait
Copy link
Member

@hendrikmakait hendrikmakait commented Jul 21, 2023 •
edited

Sibling to dask/dask#10424

  • Tests added / passed
  • Passes pre-commit run --all-files

@hendrikmakait hendrikmakait changed the title Fix compatability variable naming Fix compatibility variable naming Jul 21, 2023
crusaderky
crusaderky approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@crusaderky crusaderky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; waiting for parent PR

@hendrikmakait hendrikmakait merged commit efc7eeb into dask:main Jul 24, 2023
23 of 26 checks passed
@hendrikmakait hendrikmakait deleted the ge-not-gt branch July 24, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crusaderky crusaderky crusaderky approved these changes

@fjetter fjetter Awaiting requested review from fjetter fjetter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hendrikmakait @crusaderky