Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic tweak to adaptive_target #8052

Merged
merged 2 commits into from Jul 31, 2023

Conversation

crusaderky
Copy link
Collaborator

Trivial follow-up to #8037

@crusaderky crusaderky requested a review from fjetter as a code owner July 31, 2023 12:08
@crusaderky crusaderky self-assigned this Jul 31, 2023
@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       19 files   -     1         19 suites   - 1   10h 38m 14s ⏱️ + 17m 31s
  3 745 tests  -     3    3 631 ✔️ +    2     106 💤  - 2    8  - 1 
33 823 runs   - 457  32 129 ✔️  - 444  1 682 💤  - 8  12  - 3 

For more details on these failures, see this check.

Results for commit 396c205. ± Comparison against base commit a7f7764.

This pull request removes 3 tests.
distributed.cli.tests.test_dask_worker.test_listen_address_ipv6[tcp:..[ ‑ 1]:---nanny]
distributed.cli.tests.test_dask_worker.test_listen_address_ipv6[tcp:..[ ‑ 1]:---no-nanny]
pytest ‑ internal

Comment on lines 8082 to +8084
if tasks_ready > cpu:
break
tasks_ready += len(ws.processing)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not cosmetic but a very minor change to the logic, isn't it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's cosmetic because tasks_ready is not used afterwards. Only cpu is used, and that variable won't change its value in any use case after this change.

@crusaderky crusaderky merged commit 9a9d2c3 into dask:main Jul 31, 2023
17 of 27 checks passed
@crusaderky crusaderky deleted the cosmetic_adaptive_target branch July 31, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants