Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky test_worker_metrics #8069

Merged
merged 1 commit into from Aug 3, 2023
Merged

Fix flaky test_worker_metrics #8069

merged 1 commit into from Aug 3, 2023

Conversation

crusaderky
Copy link
Collaborator

Closes #8068

fjetter
fjetter approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@fjetter fjetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I encountered even examples where there were more items. Now rerunning it, it seems to be just ordering. I'm glad if that's all there is to it

@fjetter
Copy link
Member

fjetter commented Aug 3, 2023

Thanks for the quick reaction

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       20 files  ±0         20 suites  ±0   11h 20m 36s ⏱️ + 9m 4s
  3 754 tests ±0    3 643 ✔️ +1     106 💤 ±0  5 ❌  - 1 
36 314 runs  ±0  34 560 ✔️ +3  1 748 💤 ±0  6 ❌  - 3 

For more details on these failures, see this check.

Results for commit 44a6d04. ± Comparison against base commit 84e1984.

@fjetter fjetter merged commit 4633e6e into dask:main Aug 3, 2023
20 of 28 checks passed
@crusaderky crusaderky deleted the test_worker_metrics branch August 4, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjetter fjetter fjetter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky test_send_metrics_to_scheduler
2 participants
@crusaderky @fjetter