Better logging for anomalous task termination #8082
Conversation
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 20 files ±0 20 suites ±0 11h 31m 28s ⏱️ + 35m 38s For more details on these failures, see this check. Results for commit 640c592. ± Comparison against base commit ef6d4bf. ♻️ This comment has been updated with latest results. |
| return | ||
| except BaseException: # pragma: nocover | ||
| logger.exception("async instruction handlers should never raise!") | ||
| # This should never happen | ||
| logger.exception(f"Unhandled exception in async instruction for {task}") |
There was a problem hiding this comment.
Not intended as blocking comment, but I could see it being useful if we included the type of the exception and possibly the exception message here.
There was a problem hiding this comment.
logger.exception automatically does that
|
As |
Follow-up to #8006
In #8006, CancelledError not only caused the worker state machine to deadlock, but it also left no trace in the log.
While #8013 prevents this specific issue, it's wise to ensure that CancelledError is never silently ignored.