Fix additional race condition that can cause P2P restart to deadlock #8094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendrikmakait
commented
Aug 10, 2023
Comment on lines
+451
to
+459
| await async_poll_for(lambda: len(s.running) == 1, timeout=5) | ||
| b.close_gracefully() | ||
| await b.process.process.kill() | ||
|
|
||
| while s.running: | ||
| await asyncio.sleep(0.01) | ||
| await async_poll_for(lambda: not s.running, timeout=5) | ||
|
|
||
| a.status = Status.running | ||
|
|
||
| while not s.running: | ||
| await asyncio.sleep(0.01) | ||
| pass | ||
| await async_poll_for(lambda: s.running, timeout=5) |
There was a problem hiding this comment.
These changes are merely for easier debugging.
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 20 files ± 0 20 suites ±0 12h 21m 26s ⏱️ + 1h 14m 27s For more details on these failures, see this check. Results for commit ffd3a1b. ± Comparison against base commit 163165b. This pull request removes 2 tests. |
|
cc @wence- |
fjetter
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8088
Follow-up to #8091
Race condition description: #8088 (comment)
pre-commit run --all-files