Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use asyncio.timeout() in ConnectionPool where available #8109

Merged

Conversation

graingert
Copy link
Member

@graingert graingert commented Aug 15, 2023

alternative to #8108

  • Tests added / passed
  • Passes pre-commit run --all-files

@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2023

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       21 files  ±  0         21 suites  ±0   12h 1m 2s ⏱️ + 34m 21s
  3 777 tests +  7    3 666 ✔️ +  5     108 💤 +1  3 +1 
36 515 runs  +58  34 702 ✔️ +49  1 809 💤 +7  4 +2 

For more details on these failures, see this check.

Results for commit 914f910. ± Comparison against base commit 3082d27.

♻️ This comment has been updated with latest results.

@graingert graingert force-pushed the use-structured-concurrency-in-comm-pool-cancel branch from 7f69e5a to 9968716 Compare August 16, 2023 10:19
Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @graingert!

@graingert graingert merged commit 6584e5c into dask:main Aug 23, 2023
23 of 28 checks passed
@graingert graingert deleted the use-structured-concurrency-in-comm-pool-cancel branch August 23, 2023 12:43
crusaderky added a commit to crusaderky/dask that referenced this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants