Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge with P2P shuffle fails if left_index or right_index is True #8121

Merged
merged 1 commit into from Aug 21, 2023

Conversation

phofl
Copy link
Collaborator

@phofl phofl commented Aug 21, 2023

  • Tests added / passed
  • Passes pre-commit run --all-files

This is raising on main

@phofl phofl requested a review from fjetter as a code owner August 21, 2023 15:14
@phofl phofl changed the title Merge with P2P shuffle fails if left_index or right_idnex is True Merge with P2P shuffle fails if left_index or right_index is True Aug 21, 2023
@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       21 files  ±  0         21 suites  ±0   12h 11m 13s ⏱️ + 20m 32s
  3 777 tests +  4    3 667 ✔️ +  6     108 💤 ±0  2  - 2 
36 515 runs  +43  34 703 ✔️ +52  1 809 💤  - 8  3  - 1 

For more details on these failures, see this check.

Results for commit 4282c8a. ± Comparison against base commit 716d526.

Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @phofl!

@hendrikmakait hendrikmakait merged commit acb2809 into dask:main Aug 21, 2023
25 of 29 checks passed
@phofl phofl deleted the p2p_merge branch August 21, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants