Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings from pandas=2.1.0 #8145

Merged
merged 1 commit into from Aug 31, 2023
Merged

Fix warnings from pandas=2.1.0 #8145

merged 1 commit into from Aug 31, 2023

Conversation

phofl
Copy link
Collaborator

@phofl phofl commented Aug 31, 2023

Closes #xxxx

  • Tests added / passed
  • Passes pre-commit run --all-files

The sparse warning comes from arrow, but as far as I can see we are not using from_pandas anywhere outside of tests, so we should be good

@phofl phofl requested a review from fjetter as a code owner August 31, 2023 13:53
@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       21 files  ±         0         21 suites  ±0   10h 55m 26s ⏱️ + 9h 37m 25s
  3 785 tests +     445    3 676 ✔️ +     569     107 💤  - 124  2 +2 
36 587 runs  +29 777  34 784 ✔️ +28 826  1 800 💤 +970  3 +3 

For more details on these failures, see this check.

Results for commit c6b927a. ± Comparison against base commit ec40daa.

This pull request skips 2 and un-skips 138 tests.
distributed.protocol.tests.test_arrow
distributed.protocol.tests.test_pandas
distributed.cli.tests.test_dask_worker ‑ test_dashboard_non_standard_ports
distributed.cli.tests.test_dask_worker ‑ test_listen_address_ipv6[tcp://:---nanny]
distributed.cli.tests.test_dask_worker ‑ test_listen_address_ipv6[tcp://:---no-nanny]
distributed.cli.tests.test_dask_worker ‑ test_listen_address_ipv6[tcp://[::1]:---nanny]
distributed.cli.tests.test_dask_worker ‑ test_listen_address_ipv6[tcp://[::1]:---no-nanny]
distributed.comm.tests.test_comms ‑ test_default_client_server_ipv6[asyncio]
distributed.comm.tests.test_comms ‑ test_default_client_server_ipv6[tornado]
distributed.comm.tests.test_comms ‑ test_tcp_client_server_ipv6[asyncio]
distributed.comm.tests.test_comms ‑ test_tcp_client_server_ipv6[tornado]
distributed.comm.tests.test_comms ‑ test_tls_client_server_ipv6[asyncio]
…

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phofl!

@@ -141,6 +141,7 @@ filterwarnings = [
'''ignore:notifyAll\(\) is deprecated, use notify_all\(\) instead:DeprecationWarning:paramiko''',
'''ignore:setDaemon\(\) is deprecated, set the daemon attribute instead:DeprecationWarning:paramiko''',
'''ignore:`np.bool8` is a deprecated alias for `np.bool_`''',
'''ignore:is_sparse is deprecated and will:FutureWarning''',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this is resolved in pyarrow=13 (xref apache/arrow#35366)

@jrbourbeau jrbourbeau changed the title Fix warnings from new pandas version Fix warnings from pandas=2.1.0 Aug 31, 2023
@jrbourbeau jrbourbeau merged commit e79c0c7 into dask:main Aug 31, 2023
26 of 30 checks passed
@phofl phofl deleted the pandas_release branch August 31, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants