Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure en error during ShuffleRun.close cannot block worker shutdown #8184

Merged
merged 2 commits into from Sep 14, 2023

Conversation

fjetter
Copy link
Member

@fjetter fjetter commented Sep 13, 2023

Any error during ShuffleRun.close can block the shutdown since the condition will block until the run is cleaned up. The exception is otherwise not handled and never retrieved. Therefore, we're logging it and clean up the state.

An example of an exception that could happen here is the failure to remove files of the disk buffer. There are surely other "not great but OK" cases.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       21 files  ±  0         21 suites  ±0   11h 3m 28s ⏱️ -18s
  3 817 tests +  1    3 705 ✔️  -   1     107 💤 ±0  5 +2 
36 895 runs  +20  35 091 ✔️ +23  1 799 💤  - 5  5 +2 

For more details on these failures, see this check.

Results for commit 2d9e1b6. ± Comparison against base commit 9895194.

♻️ This comment has been updated with latest results.

@fjetter fjetter merged commit 9129dae into dask:main Sep 14, 2023
22 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants