Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reset CUDA context after UCX tests #8201

Merged
merged 4 commits into from Sep 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion distributed/comm/tests/test_ucx.py
Expand Up @@ -179,7 +179,7 @@ async def test_ucx_deserialize(ucx_loop):
"g",
[
lambda cudf: cudf.Series([1, 2, 3]),
lambda cudf: cudf.Series([]),
lambda cudf: cudf.Series([], dtype=object),
lambda cudf: cudf.DataFrame([]),
lambda cudf: cudf.DataFrame([1]).head(0),
lambda cudf: cudf.DataFrame([1.0]).head(0),
Expand Down
11 changes: 0 additions & 11 deletions distributed/utils_test.py
Expand Up @@ -2156,17 +2156,6 @@ def ucx_loop():
import distributed.comm.ucx

distributed.comm.ucx.ucp = None
# If the test created a context, clean it up.
# TODO: should we check if there's already a context _before_ the test runs?
# I think that would be useful.
from distributed.diagnostics.nvml import has_cuda_context

ctx = has_cuda_context()
if ctx.has_context:
import numba.cuda

ctx = numba.cuda.current_context()
ctx.device.reset()


def wait_for_log_line(
Expand Down