Shutdown scheduler cleanly on JupyterLab shutdown #8220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
force-pushed
the
shutdown-scheduler-cleanly-on-jupyterlab-shutdown
branch
from
bfc6d65
to
c6c78c7
Compare
graingert
force-pushed
the
shutdown-scheduler-cleanly-on-jupyterlab-shutdown
branch
from
b7687d7
to
2a35cab
Compare
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 21 files ± 0 21 suites ±0 10h 30m 40s ⏱️ - 31m 47s For more details on these failures, see this check. Results for commit 2a35cab. ± Comparison against base commit a74f7cf. |
4 tasks
jrbourbeau
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Thanks @graingert! I tried this out and things are working as expected
jrbourbeau
changed the title
graingert
deleted the
shutdown-scheduler-cleanly-on-jupyterlab-shutdown
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8219
pre-commit run --all-files