Prevent race condition in P2P shuffle run manager #8262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendrikmakait
commented
Oct 12, 2023
Comment on lines
203
to
+204
| ) -> ShuffleRun: | ||
| # FIXME: This should never be ToPickle[ShuffleRunSpec] | ||
| result: ShuffleRunSpec | ToPickle[ShuffleRunSpec] | ||
| if spec is None: | ||
| result = await self._plugin.worker.scheduler.shuffle_get( | ||
| id=shuffle_id, | ||
| worker=self._plugin.worker.address, | ||
| ) | ||
| else: | ||
| result = await self._plugin.worker.scheduler.shuffle_get_or_create( | ||
| spec=ToPickle(spec), | ||
| key=key, | ||
| worker=self._plugin.worker.address, | ||
| ) | ||
| if isinstance(result, ToPickle): | ||
| result = result.data | ||
| result = await self._fetch(shuffle_id=shuffle_id, spec=spec, key=key) |
There was a problem hiding this comment.
This code has been moved into _fetch
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 21 files + 1 21 suites +1 10h 44m 28s ⏱️ + 45m 47s For more details on these failures, see this check. Results for commit 19cca42. ± Comparison against base commit cb3da26. |
8 tasks
crusaderky
reviewed
Oct 13, 2023
| key=key, | ||
| worker=self._plugin.worker.address, | ||
| ) | ||
| if isinstance(result, ToPickle): |
There was a problem hiding this comment.
out of scope: I'm not sure I understand why this may or may not be wrapped in ToPickle?
There was a problem hiding this comment.
It's something in the comms, haven't dug too deep into it.
Co-authored-by: crusaderky <crusaderky@gmail.com>
Co-authored-by: crusaderky <crusaderky@gmail.com>
hendrikmakait
force-pushed
the
p2p-stale-race
branch
from
23d233c
to
ba0d7da
Compare
crusaderky
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a potential race condition in P2P shuffling between the stream-based
shuffle_failand the RPC-basedgetandget_or_create. This race can cause a worker to cache a stale shuffle run locally and tasks to perform their work on a stale run. This PR prevents this.pre-commit run --all-files