Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix /shuffle dashboard with in-memory storage #8293

Merged
merged 1 commit into from Oct 24, 2023

Conversation

hendrikmakait
Copy link
Member

Fixes

bokeh.util.tornado - ERROR - Traceback (most recent call last):
  File "/opt/coiled/env/lib/python3.11/site-packages/tornado/gen.py", line 530, in callback
    result_list.append(f.result())
                       ^^^^^^^^^^
  File "/opt/coiled/env/lib/python3.11/site-packages/bokeh/server/session.py", line 94, in _needs_document_lock_wrapper
    result = func(self, *args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/coiled/env/lib/python3.11/site-packages/bokeh/server/session.py", line 226, in with_document_locked
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/coiled/env/lib/python3.11/site-packages/bokeh/document/callbacks.py", line 485, in wrapper
    return invoke_with_curdoc(doc, invoke)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/coiled/env/lib/python3.11/site-packages/bokeh/document/callbacks.py", line 443, in invoke_with_curdoc
    return f()
           ^^^
  File "/opt/coiled/env/lib/python3.11/site-packages/bokeh/document/callbacks.py", line 484, in invoke
    return f(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^
  File "/opt/coiled/env/lib/python3.11/site-packages/distributed/dashboard/components/__init__.py", line 41, in <lambda>
    doc.add_periodic_callback(lambda: update(ref), interval)
                                      ^^^^^^^^^^^
  File "/opt/coiled/env/lib/python3.11/site-packages/bokeh/core/property/validation.py", line 95, in func
    return input_function(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/coiled/env/lib/python3.11/site-packages/distributed/dashboard/components/__init__.py", line 49, in update
    comp.update()
  File "/opt/coiled/env/lib/python3.11/site-packages/bokeh/core/property/validation.py", line 95, in func
    return input_function(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/coiled/env/lib/python3.11/site-packages/distributed/dashboard/components/scheduler.py", line 4476, in update
    elif d[prefix]["memory"] > d[prefix]["memory_limit"]:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: '>' not supported between instances of 'int' and 'NoneType'
  • Tests added / passed
  • Passes pre-commit run --all-files

@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       27 files  ±0         27 suites  ±0   15h 41m 5s ⏱️ - 19m 58s
  3 932 tests ±0    3 812 ✔️ +3     115 💤 ±0    5  - 3 
49 387 runs  ±0  47 019 ✔️ +5  2 341 💤 ±0  27  - 5 

For more details on these failures, see this check.

Results for commit 44400ec. ± Comparison against base commit 095a09d.

Copy link
Collaborator

@crusaderky crusaderky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be reasonable to add a test for it?

@hendrikmakait
Copy link
Member Author

would it be reasonable to add a test for it?

In principle, yes, in practice, I'd like to add general testing for the dashboard in a follow-up.

Copy link
Contributor

@milesgranger milesgranger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me! 👍

@crusaderky crusaderky merged commit d0af984 into dask:main Oct 24, 2023
20 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants