Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test_resources_reset_after_cancelled_task #8373

Merged

Conversation

crusaderky
Copy link
Collaborator

@crusaderky crusaderky commented Nov 27, 2023

Fix race condition when future.cancel() travels slower from client to scheduler than lock.release travels from client to scheduler to worker.

https://github.com/dask/distributed/pull/8367/checks?check_run_id=19069185771


        await future.cancel()
        await lock.release()
    
        while w.state.executing_count:
            await asyncio.sleep(0.01)
    
>       assert not s.workers[w.address].used_resources["A"]
E       assert not 1

@crusaderky crusaderky added the flaky test Intermittent failures on CI. label Nov 27, 2023
@crusaderky crusaderky self-assigned this Nov 27, 2023
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       27 files  ±  0         27 suites  ±0   11h 53m 44s ⏱️ + 1m 44s
  3 934 tests ±  0    3 821 ✔️ +  2     110 💤 ±0  3  - 2 
49 488 runs  +18  47 195 ✔️ +26  2 290 💤  - 6  3  - 2 

For more details on these failures, see this check.

Results for commit 2423b62. ± Comparison against base commit a7cf54f.

Copy link
Contributor

@milesgranger milesgranger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@crusaderky crusaderky merged commit 6d1e133 into dask:main Nov 29, 2023
32 of 35 checks passed
@crusaderky crusaderky deleted the test_resources_reset_after_cancelled_task branch November 29, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky test Intermittent failures on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants