Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite test_subprocess_cluster_does_not_depend_on_logging #8409

Conversation

hendrikmakait
Copy link
Member

Closes #8408

  • Tests added / passed
  • Passes pre-commit run --all-files

Copy link
Contributor

github-actions bot commented Dec 14, 2023

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       27 files  ±0         27 suites  ±0   11h 58m 42s ⏱️ + 11m 57s
  3 937 tests  - 1    3 822 ✔️ ±  0     112 💤 ±0    3  - 1 
49 523 runs  +5  47 193 ✔️ +14  2 318 💤  - 6  12  - 3 

For more details on these failures, see this check.

Results for commit 2a63274. ± Comparison against base commit f2e1e51.

This pull request removes 1 test.
distributed.tests.test_worker ‑ test_gpu_executor

♻️ This comment has been updated with latest results.

@hendrikmakait
Copy link
Member Author

It's odd to see this test take more than 5 seconds on Mac OS on CI...locally, it works in 0.6

@hendrikmakait hendrikmakait marked this pull request as draft December 14, 2023 12:33
@hendrikmakait hendrikmakait changed the title Increase timeout for test_subprocess_cluster_does_not_depend_on_logging Rewrite test_subprocess_cluster_does_not_depend_on_logging Dec 14, 2023
@hendrikmakait hendrikmakait marked this pull request as ready for review December 14, 2023 17:13
@hendrikmakait hendrikmakait merged commit 5b0dfa4 into dask:main Dec 14, 2023
21 of 34 checks passed
@hendrikmakait hendrikmakait deleted the test_subprocess_cluster_does_not_depend_on_logging-fix branch December 14, 2023 18:15
Vesyrak pushed a commit to Vesyrak/distributed that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_subprocess_cluster_does_not_depend_on_logging is broken on Python 3.12
2 participants