Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid deadlock in P2P hash join if worker joins late #8415

Merged
merged 5 commits into from Dec 15, 2023

Conversation

hendrikmakait
Copy link
Member

Closes #8411

  • Tests added / passed
  • Passes pre-commit run --all-files

Copy link
Contributor

github-actions bot commented Dec 15, 2023

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       27 files  ±  0         27 suites  ±0   11h 55m 40s ⏱️ - 3m 10s
  3 940 tests +  1    3 827 ✔️  - 2     108 💤 ±0  5 +3 
49 558 runs  +11  47 282 ✔️ +8  2 271 💤 +1  5 +2 

For more details on these failures, see this check.

Results for commit d1d6e01. ± Comparison against base commit 3882bc6.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@crusaderky crusaderky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my latest commit

@hendrikmakait
Copy link
Member Author

Thanks, @crusaderky!

@crusaderky crusaderky merged commit c76b4be into dask:main Dec 15, 2023
28 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

P2P hash joins deadlock if workers are replaced
2 participants