Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not run gilknocker in testsuite #8423

Merged
merged 3 commits into from Dec 21, 2023
Merged

Do not run gilknocker in testsuite #8423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
031e9d7
Do not run gilknocker in testsuite
fjetter Dec 19, 2023
7d671ab
fix tests
fjetter Dec 19, 2023
2f5bf41
Merge branch 'main' into pr/fjetter/8423
hendrikmakait Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion distributed/http/scheduler/tests/test_scheduler_http.py
View file
Open in desktop
Expand Up @@ -98,7 +98,13 @@ async def test_prefix(c, s, a, b):
assert is_valid_xml(body)


@gen_cluster(client=True, clean_kwargs={"threads": False})
@gen_cluster(
client=True,
clean_kwargs={"threads": False},
config={
"distributed.admin.system-monitor.gil.enabled": True,
},
)
async def test_prometheus(c, s, a, b):
pytest.importorskip("prometheus_client")

Expand Down
8 changes: 7 additions & 1 deletion distributed/http/worker/tests/test_worker_http.py
View file
Open in desktop
Expand Up @@ -15,7 +15,13 @@
)


@gen_cluster(client=True, nthreads=[("127.0.0.1", 1)])
@gen_cluster(
client=True,
nthreads=[("127.0.0.1", 1)],
config={
"distributed.admin.system-monitor.gil.enabled": True,
},
)
async def test_prometheus(c, s, a):
pytest.importorskip("prometheus_client")

Expand Down
1 change: 1 addition & 0 deletions distributed/utils_test.py
View file
Open in desktop
Expand Up @@ -1814,6 +1814,7 @@ def config_for_cluster_tests(**extra_config):
"distributed.scheduler.validate": True,
"distributed.worker.validate": True,
"distributed.worker.profile.enabled": False,
"distributed.admin.system-monitor.gil.enabled": False,
},
**extra_config,
):
Expand Down