Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid deprecated shuffle keyword #8439

Merged
merged 2 commits into from Jan 4, 2024

Conversation

hendrikmakait
Copy link
Member

Sibling to dask/dask#10724

This PR goes one step further than required by dask/dask#10724 and avoids using keyword arguments altogether.

  • Tests added / passed
  • Passes pre-commit run --all-files

@hendrikmakait hendrikmakait marked this pull request as ready for review January 3, 2024 17:32
Copy link
Contributor

github-actions bot commented Jan 3, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    27 files  ±0      27 suites  ±0   9h 40m 10s ⏱️ - 5m 47s
 3 951 tests ±0   3 841 ✅ +3    109 💤 ±0  1 ❌  - 3 
49 678 runs  ±0  47 383 ✅ +4  2 294 💤  - 1  1 ❌  - 3 

For more details on these failures, see this check.

Results for commit be447ba. ± Comparison against base commit 81774d4.

@phofl phofl merged commit e8e9f70 into dask:main Jan 4, 2024
31 of 34 checks passed
@phofl
Copy link
Collaborator

phofl commented Jan 4, 2024

thx @hendrikmakait

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants