Typing tweaks in scheduler.py #8551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
commented
Mar 4, 2024
| if hosts is not None: | ||
| for host in hosts: | ||
| dh: dict = self.host_info.get(host) # type: ignore | ||
| dh = self.host_info.get(host) | ||
| if dh is not None: | ||
| workers.extend(dh["addresses"]) |
There was a problem hiding this comment.
Fixed antipattern where the function alters its parameter
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 27 files ±0 27 suites ±0 10h 0m 46s ⏱️ + 3m 11s For more details on these failures, see this check. Results for commit 8370461. ± Comparison against base commit c8974d6. ♻️ This comment has been updated with latest results. |
milesgranger
approved these changes
Mar 5, 2024
crusaderky
force-pushed
the
cosmetic
branch
3 times, most recently
from
4725e9a
to
985c369
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets rid of all of these mypy output lines