Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test_raise_on_incompatible_partitions #8571

Merged

Conversation

crusaderky
Copy link
Collaborator

@crusaderky crusaderky commented Mar 11, 2024

e.g. https://github.com/dask/distributed/pull/8569/checks?check_run_id=22516322786

E           AssertionError: Regex pattern did not match.
E            Regex: 'shuffling \\w* failed'
E            Input: 'shuffle_barrier failed during shuffle c593d0fd37e591da8ff25429ed7c9655'


with raises_with_cause(
RuntimeError,
r"(shuffling \w*|shuffle_barrier) failed",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is the important bit; the rest is just code hygene

@crusaderky crusaderky added the flaky test Intermittent failures on CI. label Mar 11, 2024
Copy link
Contributor

github-actions bot commented Mar 11, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    27 files  ±0      27 suites  ±0   10h 17m 1s ⏱️ - 5m 36s
 4 050 tests ±0   3 938 ✅ ±0    110 💤 ±0  2 ❌ ±0 
50 854 runs  ±0  48 519 ✅ +1  2 333 💤  - 1  2 ❌ ±0 

For more details on these failures, see this check.

Results for commit d1a6b82. ± Comparison against base commit 8a1ecb8.

♻️ This comment has been updated with latest results.

@crusaderky crusaderky force-pushed the test_raise_on_incompatible_partitions branch from d72b25e to d1a6b82 Compare March 11, 2024 20:06
Copy link
Contributor

@milesgranger milesgranger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @crusaderky!

@crusaderky crusaderky merged commit 40daaf0 into dask:main Mar 12, 2024
30 of 34 checks passed
@crusaderky crusaderky deleted the test_raise_on_incompatible_partitions branch March 12, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky test Intermittent failures on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants