Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GPU Dashboard #8572

Merged
merged 2 commits into from Mar 28, 2024
Merged

Fix GPU Dashboard #8572

merged 2 commits into from Mar 28, 2024

Conversation

quasiben
Copy link
Member

Closes #8567

In #8399 we removed the GPU Executor which caused an outage in the GPU dashboard. This was due to relyin on the ws.extra['gpu'] being populated by the executor. The dashboard now relies on the system monitor for pulling and updating GPU memory/usage

@jacobtomlinson @charlesbluca Can one of you review ?

  • Tests added / passed
  • Passes pre-commit run --all-files

@quasiben quasiben requested a review from fjetter as a code owner March 11, 2024 16:46
Copy link
Contributor

github-actions bot commented Mar 11, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    29 files  ±0      29 suites  ±0   10h 56m 8s ⏱️ - 25m 53s
 4 058 tests ±0   3 943 ✅  - 5    109 💤 ±0  5 ❌ +4  1 🔥 +1 
54 931 runs  +1  52 520 ✅  - 2  2 405 💤  - 2  5 ❌ +4  1 🔥 +1 

For more details on these failures and errors, see this check.

Results for commit 6ea9470. ± Comparison against base commit e434793.

♻️ This comment has been updated with latest results.

@mrocklin
Copy link
Member

@fjetter can I ask your team to take a look at this? (or @jrbourbeau)

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @quasiben. This LGTM -- here's a screenshot of trying this PR out

Screenshot 2024-03-27 at 6 00 06 PM

There were some seemingly unrelated test failures happening, so I merged main. Will merge this PR once CI finishes

EDIT: Confirmed the failures here are known flaky tests

@jrbourbeau jrbourbeau merged commit e7f756b into dask:main Mar 28, 2024
30 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GPU Utilization chart doesn't show in vanilla dask
3 participants