Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test_restart_waits_for_new_workers #8573

Merged
merged 1 commit into from Mar 12, 2024

Conversation

crusaderky
Copy link
Collaborator

@crusaderky crusaderky commented Mar 11, 2024

https://github.com/dask/distributed/pull/8571/checks?check_run_id=22534355076

>       assert s.workers.keys().isdisjoint(original_workers.keys())
E       AssertionError: assert False

@crusaderky crusaderky self-assigned this Mar 11, 2024
@crusaderky crusaderky added the flaky test Intermittent failures on CI. label Mar 11, 2024
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    27 files  ±0      27 suites  ±0   9h 52m 28s ⏱️ - 30m 9s
 4 050 tests ±0   3 938 ✅ ±0    110 💤 ±0  2 ❌ ±0 
50 854 runs  ±0  48 518 ✅ ±0  2 334 💤 ±0  2 ❌ ±0 

For more details on these failures, see this check.

Results for commit 1dcd851. ± Comparison against base commit 8a1ecb8.

Copy link
Contributor

@milesgranger milesgranger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @crusaderky!

@crusaderky crusaderky merged commit 54ed6a1 into dask:main Mar 12, 2024
31 of 35 checks passed
@crusaderky crusaderky deleted the test_restart_waits_for_new_workers branch March 12, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky test Intermittent failures on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants