Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure workers are not downscaled when participating in p2p #8610

Merged
merged 1 commit into from Apr 12, 2024

Conversation

fjetter
Copy link
Member

@fjetter fjetter commented Apr 9, 2024

Closes #8579

@fjetter fjetter changed the title ensure workers are not downscaled when participating in p2p Ensure workers are not downscaled when participating in p2p Apr 9, 2024
Copy link
Contributor

github-actions bot commented Apr 9, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    29 files  ± 0      29 suites  ±0   10h 57m 36s ⏱️ - 17m 53s
 4 061 tests + 1   3 948 ✅ + 1    109 💤 ±0  4 ❌ ±0 
54 970 runs  +30  52 557 ✅ +36  2 409 💤  - 6  4 ❌ ±0 

For more details on these failures, see this check.

Results for commit 9b302e7. ± Comparison against base commit 66ced13.

♻️ This comment has been updated with latest results.

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great and should make life a lot easier in other deployment tools.

@fjetter fjetter force-pushed the ensure_p2p_workers_not_downscaled branch from 9279e7a to 9b302e7 Compare April 12, 2024 07:10
@fjetter fjetter merged commit e0a7525 into dask:main Apr 12, 2024
29 of 34 checks passed
@fjetter fjetter deleted the ensure_p2p_workers_not_downscaled branch April 12, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adaptive downscaling causes P2P to restart
2 participants