Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding_suspicious_worker #8647

Merged
merged 11 commits into from
Jun 5, 2024

Conversation

alex-rakowski
Copy link
Contributor

@alex-rakowski alex-rakowski commented May 9, 2024

Adds suspicious workers msg

  • Tests added / passed
  • Passes pre-commit run --all-files

@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

Copy link
Contributor

github-actions bot commented May 9, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    29 files  ± 0      29 suites  ±0   11h 5m 59s ⏱️ + 4m 46s
 4 056 tests + 5   3 953 ✅ + 8     97 💤 ±0  6 ❌  - 3 
55 869 runs  +70  53 698 ✅ +68  2 163 💤 +4  8 ❌  - 2 

For more details on these failures, see this check.

Results for commit f4aaa34. ± Comparison against base commit e4a0545.

This pull request removes 1 and adds 6 tests. Note that renamed tests count towards both.
distributed.shuffle.tests.test_shuffle ‑ test_error_receive
distributed.http.scheduler.tests.test_scheduler_http ‑ test_prometheus_collect_task_groups
distributed.shuffle.tests.test_rechunk ‑ test_partial_rechunk_taskgroups
distributed.shuffle.tests.test_shuffle ‑ test_error_receive[P2PConsistencyError]
distributed.shuffle.tests.test_shuffle ‑ test_error_receive[ValueError]
distributed.tests.test_spans ‑ test_collections_metadata
distributed.tests.test_worker ‑ test_suppress_compute_failure_for_cancelled_tasks

♻️ This comment has been updated with latest results.

@fjetter
Copy link
Member

fjetter commented May 9, 2024

add to allowlist

distributed/tests/test_client.py Outdated Show resolved Hide resolved
distributed/tests/test_client.py Outdated Show resolved Hide resolved
distributed/tests/test_client.py Outdated Show resolved Hide resolved
@alex-rakowski alex-rakowski marked this pull request as ready for review May 10, 2024 09:56
@hendrikmakait hendrikmakait self-requested a review May 10, 2024 10:02
if ts.suspicious > self.allowed_failures:
log_msg["event"] = "killed-worker"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change event to action, maybe flag as an issue to enforce it/

Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @alex-rakowski!

@hendrikmakait
Copy link
Member

It looks like test_worker_status_sync and test_log_remove_worker aren't happy :(

Can you please adjust these? (I think you simply have to add the safe keyword and value to the respective expected outputs.)

@hendrikmakait hendrikmakait self-requested a review June 3, 2024 13:29
@alex-rakowski
Copy link
Contributor Author

Those two are now passing

@hendrikmakait hendrikmakait merged commit 7cbfc4d into dask:main Jun 5, 2024
27 of 36 checks passed
@hendrikmakait
Copy link
Member

Thanks, @alex-rakowski, and congrats on getting your first contribution merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants