-
-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding_suspicious_worker #8647
Adding_suspicious_worker #8647
Conversation
Can one of the admins verify this patch? Admins can comment |
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 29 files ± 0 29 suites ±0 11h 5m 59s ⏱️ + 4m 46s For more details on these failures, see this check. Results for commit f4aaa34. ± Comparison against base commit e4a0545. This pull request removes 1 and adds 6 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
add to allowlist |
distributed/scheduler.py
Outdated
if ts.suspicious > self.allowed_failures: | ||
log_msg["event"] = "killed-worker" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change event to action, maybe flag as an issue to enforce it/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @alex-rakowski!
It looks like Can you please adjust these? (I think you simply have to add the |
Those two are now passing |
Thanks, @alex-rakowski, and congrats on getting your first contribution merged! |
Adds suspicious workers msg
pre-commit run --all-files